Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Airflow 2.9.x #87

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add support for Airflow 2.9.x #87

wants to merge 15 commits into from

Conversation

johncmerfeld
Copy link
Contributor

  • Update Resources DAG UI for compatibility with Airflow 2.9.x (backwards compatibility with prior versions is retained)
  • Due to a bug in Airflow 2.10, we must limit our version to 2.9 for the time being
  • Adds a couple of minor under-the-hood changes for compatibility

Testing

  • Changes tested in two implementations, the upgraded Airflow appears to work fine
  • Changes tested for backwards compatibility with Airflow 2.6

@johncmerfeld johncmerfeld self-assigned this Nov 20, 2024
johncmerfeld
johncmerfeld commented Nov 20, 2024
View reviewed changes
edu_edfi_airflow/providers/snowflake/transfers/s3_to_snowflake.py Outdated
Comment on lines 180 to 181
if isinstance(self.table_name, str):
self.table_name = [self.table_name] * len(self.resource)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayckaiser I don't think I added this code - was it removed from main recently?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johncmerfeld It appears that I did remove this from main in the latest commit.

We need to make sure that nothing else has changed between when this was branched and current main.

jayckaiser
jayckaiser reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@jayckaiser jayckaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a piece of code that snuck back into the codebase in the S3ToSnowflakeOperator. I think this is the only straggler, but keep an eye out for others.

@johncmerfeld
Copy link
Contributor Author

I left a comment about a piece of code that snuck back into the codebase in the S3ToSnowflakeOperator. I think this is the only straggler, but keep an eye out for others.

@jayckaiser we should be good now. I'm certain all the remaining diffs are what Sam and I added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayckaiser jayckaiser jayckaiser left review comments

@rlittle08 rlittle08 Awaiting requested review from rlittle08

At least 1 approving review is required to merge this pull request.

Assignees

@johncmerfeld johncmerfeld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johncmerfeld @jayckaiser @sleblanc23