Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to local fonts b/c the alternative is dumb #137

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

aslink87
Copy link
Member

fixes #61

We were using next/fonts and users were sometimes unable to download the fonts causing fallbacks to render.
Here I've moved to only local fonts for the project.

This involved:

  • refactoring route headings to use a custom <PageHeading> component that applies a local heading font
  • defaulted the entire app to a local body font
  • had to update the side nav drawer a bit to allow for the component
  • Chakra is failing to apply custom fonts in its extendTheme function. If that wasn't the case we could have defined the heading and body fonts there instead of injecting them in a custom <PageHeader> component, or importing them within the app.

app/_lib/moduleProps.tsx Show resolved Hide resolved
@aslink87 aslink87 merged commit 054733a into development Apr 28, 2024
2 checks passed
@aslink87 aslink87 deleted the local-font branch May 18, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts intermittently don't load in development environment
3 participants