Better environment, presentations, guile, and MIT support. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use this for the package data in swank:connection-info.
And use it where appropriate. param:environment is not the same thing.
And fix bugs with environment handling in the shared code.
Support is still lame because guile doesn't have good arglists for its functions.
The current environment the REPL executes forms in no longer needs to contain the binding for swank:lookup-presented-object-or-lose. The form is evaluated at read-time, as intended.
rgherdt
reviewed
Dec 12, 2024
| @@ -264,7 +278,7 @@ The secondary value indicates the absence of an entry." | |||
| (if (and (list? x) | |||
| (eq? (car x) 'quote)) | |||
| (cond ((string? (cadr x)) | |||
| (cadr x)) | |||
| (read-from-string (cadr x))) | |||
There was a problem hiding this comment.
I'm not really familiar with the code, but why should unquote-string return something different than a string?
|
Besides my comment regarding |
rgherdt
reviewed
Dec 15, 2024
| (let* ((pattern "#.(swank:lookup-presented-object-or-lose ") | ||
| (start (string-contains string pattern))) | ||
| (if start | ||
| (replace-readtime-lookup-presented-object-or-lose | ||
| (string-replace string "" start (+ 2 start))) | ||
| string))) | ||
|
|
||
| (define (replace-lookup-presented-object-or-lose form) |
There was a problem hiding this comment.
As I see, it's an workaround until proper lookup is implemented, right? In which cases slime sends these commands? Perhaps some TODO-comments with context information would be helpful.
rgherdt
reviewed
Dec 15, 2024
| (format #f "~a" (frame-procedure-name fr))) | ||
| (format #f "~a ~a" | ||
| (frame-procedure-name fr) | ||
| (frame-arguments fr))) |
There was a problem hiding this comment.
alternatively, one can use frame-call-representation (see PR #17 ). But we can leave this change said PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.