Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 changes #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

3 changes #20

wants to merge 1 commit into from

Conversation

tsohr
Copy link

@tsohr tsohr commented Aug 26, 2014

  • Fix missing chosen js library
    • Currently unable to connect to cdnjs.cloudflare.com
    • Download it and hold it statically.
  • Add InfoWindow on google map
    • Double click on the map, open a InfoWindow to the closest point
  • Remove sparkline data from the table
    • Performance on the mobile device was very poor

@tsohr tsohr changed the title 3 major changes 3 changes Aug 26, 2014
@econpy
Copy link
Owner

econpy commented Aug 27, 2014

I'm looking through your changes and will be able to accept a few of them. I'm not done yet, but all 3 of your bullet points are items I think are good suggestions.

I did notice 2 problematic changes that you made though in other files:

  1. The PIDs you added to torque_keys.csv here already exist in that file, although they do not have the '0' after the 'k'. In the request Ian's app does to the upload_data.php script, keys of the form k0[0-9a-f] do not include the 0.
  2. The setting of the timezone change you made here works if and only if the user is on the same timezone as the server. The PHP expression ini_get('date.timezone') will return the timezone of the server. For people using hosting services like iPage, this will make all their timestamps render in the timezone of iPage's server. The method I have in place already uses JQuery to get the timezone of the user, based on the computer they are sitting at, and then passes that to PHP as a session variable called time. One downside of my method is that it causes the page to refresh right after visiting the session.php page (the first page load is when JQuery grabs the timezone of the users computer, then it refreshes the page and passes the correct timezone to PHP on the second load). For reference, my solution comes from this stackoverflow answer. If you have a better solution that will work universally for all users of any server configuration, I'm all ears.

I'll follow up with more and accept some cherry-picked commits from your pull request shortly.

By the way, thanks for actively helping out and coding some of the features yourself. Don't get me wrong, everyone who simply suggests/asks for features here helps me out a great deal, but including working code with the feature is ideal -- it's definitely how we'll all get this viewer to a state that exceeds the official one!

@TwinMist
Copy link

would love to see the InfoWindow added :-)

bryankaraffa pushed a commit to bryankaraffa/torque that referenced this pull request Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants