Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
When the rendering engine is svg, and the canvas height is very high, the radius of the circle is relatively small, and the circle at the bottom cannot be drawn even though there is a drawing path.Fixed bug by changing how circles are drawn.
Fixed issues
null
Details
codesandbox demo: https://codesandbox.io/s/zrender-svg-rebuilder-bug-uuwics?file=/src/App.js
related question: https://stackoverflow.com/questions/5737975/circle-drawing-with-svgs-arc-path
related article: https://www.smashingmagazine.com/2019/03/svg-circle-decomposition-paths/
Others
因为自己所面临的场景有限,提供的解决办法,可能有很大的局限性。作为echarts的忠实用户,期待能得到官方的回应,给我一次学习和交流的机会