Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svg circle rebuilder #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aaron0502
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

When the rendering engine is svg, and the canvas height is very high, the radius of the circle is relatively small, and the circle at the bottom cannot be drawn even though there is a drawing path.Fixed bug by changing how circles are drawn.

Fixed issues

null

Details

codesandbox demo: https://codesandbox.io/s/zrender-svg-rebuilder-bug-uuwics?file=/src/App.js
related question: https://stackoverflow.com/questions/5737975/circle-drawing-with-svgs-arc-path
related article: https://www.smashingmagazine.com/2019/03/svg-circle-decomposition-paths/

Others

因为自己所面临的场景有限,提供的解决办法,可能有很大的局限性。作为echarts的忠实用户,期待能得到官方的回应,给我一次学习和交流的机会

@pissang pissang requested a review from Ovilia May 25, 2022 03:02
@Ovilia
Copy link
Member

Ovilia commented Jun 7, 2022

After running visual tests, I found all circle shapes have slight differences like this.

image

They are not noticable by human eyes. Is this acceptable? @pissang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants