Add clear defaults #60
Conversation
used for list, read, pointdb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
+ Coverage 60.24% 60.43% +0.19%
===========================================
Files 102 102
Lines 6341 6370 +29
Branches 599 603 +4
===========================================
+ Hits 3820 3850 +30
+ Misses 2521 2520 -1 ☔ View full report in Codecov by Sentry. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
mcakircali
force-pushed
the
fix/clear-defaults
branch
from
d1d59d0 to
6e3a258
Compare
| @@ -87,8 +93,8 @@ CASE( "test_metkit_expand_1" ) { | |||
|
|
|||
| CASE( "test_metkit_expand_2" ) { | |||
| { | |||
| const char* text = "ret"; | |||
| std::map<std::string, std::vector<std::string>> expected{ | |||
| const char* text = "ret,date=-1"; | |||
There was a problem hiding this comment.
@danovaro pls notice this
There was a problem hiding this comment.
is date=-1 required?
I'd like to check that we can inject the default date (-1)
Keep the current version, but please also add the previous one.
|
Private downstream CI failed. |
|
Private downstream CI failed. |
|
Private downstream CI failed. |
| @@ -87,8 +93,8 @@ CASE( "test_metkit_expand_1" ) { | |||
|
|
|||
| CASE( "test_metkit_expand_2" ) { | |||
| { | |||
| const char* text = "ret"; | |||
| std::map<std::string, std::vector<std::string>> expected{ | |||
| const char* text = "ret,date=-1"; | |||
There was a problem hiding this comment.
is date=-1 required?
I'd like to check that we can inject the default date (-1)
Keep the current version, but please also add the previous one.
restores old behavior where defaults were dropped for certain types and verbs
used for verbs: list, read, pointdb