Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable action #78

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Switch to reusable action #78

wants to merge 1 commit into from

Conversation

tmi
Copy link
Contributor

@tmi tmi commented Feb 11, 2025

Switches to reusable action, to have releases for all python versions and platforms

There are two caveats here:

  • this is realistically useful only after https://github.com/ecmwf/metkit/pull/55/files gets merged
  • the name of the resulting wheel is fdblib. That doesn't play well with findlibs.find("fdb5") (which is currently used in pyfdb), and instead findlibs.find("fdb5", "fdblib") is required. Or, we can instead name the wheel fdb5lib -- whatever you guys find suitable

@FussyDuck
Copy link

FussyDuck commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@tmi tmi force-pushed the pyWheel/reusableAction branch from 90615ba to aea3ed1 Compare February 11, 2025 14:49
@Ozaq
Copy link
Contributor

Ozaq commented Feb 11, 2025

Id prefer if the name would match the wrapped .so, i.e. libfdb5 and ofc this makes most sense if this is applied to every wrapper python module. Just my 2 cents :)

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (4f636dd) to head (cdae28e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #78   +/-   ##
========================================
  Coverage    61.51%   61.51%           
========================================
  Files          275      275           
  Lines        15245    15245           
  Branches      1556     1556           
========================================
  Hits          9378     9378           
  Misses        5867     5867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ozaq Ozaq force-pushed the pyWheel/reusableAction branch from aea3ed1 to cdae28e Compare February 12, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants