-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cubed sphere 2 grid builder #253
Cubed sphere 2 grid builder #253
Conversation
Please rebase on develop and mark as ready for review when you want me to have a look. |
c5c4b7a
to
5211606
Compare
5211606
to
984524d
Compare
Hi @mo-jonasganderton, with the new CS approach the Projection can be arbitrary and probably should not derive from a dedicated one for the CS. |
Caution This pull request contains changes to GitHub workflows! |
1 similar comment
Caution This pull request contains changes to GitHub workflows! |
f6e44d8
to
3c2da9c
Compare
Caution This pull request contains changes to GitHub workflows! |
Hi @wdeconinck, indeed Olly mentioned removing the specific projection too, so now I have done so. Extra tests for rotation added too. |
Caution This pull request contains changes to GitHub workflows! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge! Thanks @mo-jonasganderton 🙏
Description
Part 2 of implementing a new Cubed Sphere grid (follows #245).
These changes so far include:
Impact
Once everything else is also implemented, this makes the cubed sphere more maintainable.
Checklist