Selected contributions from ACCORD-NWP (#30) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude/mpi_serial/mpi.h
to fix bug detected in VARBC_PRED:PRED_STATS
…ASSERT_MPI_INITIALISED=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains contributions from #30, as that PR cannot be merged because of conflicts.
The commits are recreated with the original authorship.
The difference is that this PR:
ELLIPS. A copy should be added to FA instead. Care needs to be taken with duplicate symbols.byteswap_modand relevant tests with a cleaner API toiswap,jswap,iswap_isle, and adds copyright headers. The functionsiswap,jswap,iswap_isleare still available without interface!Whitespace changes from #30 have already been merged in develop: 5c3ab72, a42c32c, 6852936
Ping @RyadElKhatibMF , @pmarguinaud , @AlexandreMary , @ddegrauwe for awareness, comments, reviews
As far as I'm concerned, having reviewed #30 this is OK to merge with the above differences.