-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GPU version to compile with OpenMP #180
Conversation
dfd28fc
to
f9158af
Compare
@wdeconinck this commit looks significant, but the changes here don't affect OpenACC functionality. I just made the minimum changes to permit OpenMP-offload compilation, so I don't think this PR needs much scrutiny. Could you approve? |
@wdeconinck @samhatfield I have 2 PRs, to this PR, that I would like to be a part of this. I have tested both on Nvidia devices using OpenACC. Results look good. I am going to check each on AMD devices with Cray. |
Now we can at least run the configure with OpenMP enabled.
…100s (truncation 319)
This was removed by mistake.
1e83795
to
079a464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I much appreciate the effort to look into OpenMP offloading again.
Of course! Happy to help. |
This PR permits us to build ecTrans for GPUs using OpenMP offload. It is not even remotely working yet. Here I've just done all the work necessary to run a simple test program:
I plan to add support for OpenMP offload gradually such that we can eventually run the full benchmark program. This PR is the first step.
I've also taken the opportunity to tidy up
SETUP_TRANS
.