Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow random fields in schema #2100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

buremba
Copy link

@buremba buremba commented Feb 22, 2023

The Json Schema spec lets us have additional properties in the schema. https://swagger.io/docs/specification/openapi-extensions/

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for jsonforms-examples failed.

Name Link
🔨 Latest commit bc7b6e8
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63f8dac3910a380008ba07a3

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2023

CLA assistant check
All committers have signed the CLA.

@lucas-koehler
Copy link
Contributor

Hello @buremba ,
thanks for your contribution ❤️ . I'll discuss with the team whether we want to relax the type like this.
Before we could merge this, you need to sign the Eclipse CLA (see comment #2100 (comment))

Also note that symbol cannot be used as a key here. This currently fails the build.

@buremba
Copy link
Author

buremba commented Feb 24, 2023

Done, thanks @lucas-koehler! This feature is useful to me primarily because I infer the uischema and custom renderer from the original json schema properties with x-jsonform prefix.

@buremba
Copy link
Author

buremba commented Feb 25, 2023

@lucas-koehler It looks like manual action needed to trigger CI: https://github.com/eclipsesource/jsonforms/actions/runs/4263956482

@sdirix sdirix force-pushed the master branch 2 times, most recently from 8bd14c2 to e9946ef Compare December 15, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants