Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another classgraph bump 4.8.176 #3200

Merged
merged 5 commits into from
Sep 18, 2024
Merged

another classgraph bump 4.8.176 #3200

merged 5 commits into from
Sep 18, 2024

Conversation

LorenzoBettini
Copy link
Contributor

Closes #3199

@LorenzoBettini
Copy link
Contributor Author

This increased the version in the target and POM, but in the issue I was suggesting to get rid of the pinned version (at least in the target files)

Copy link
Member

@cdietrich cdietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, what about the manifests.

@LorenzoBettini
Copy link
Contributor Author

ok, what about the manifests.

For the moment I've just increased the minimum version in the MANIFEST as well

Copy link

Test Results

  6 460 files  ± 0    6 460 suites  ±0   3h 6m 6s ⏱️ - 7m 27s
 43 242 tests ± 0   42 658 ✅ ± 0    584 💤 ±0   0 ❌ ±0 
170 120 runs   - 98  167 740 ✅  - 98  2 358 💤 ±0  22 ❌ ±0 

Results for commit 5766436. ± Comparison against base commit fb12a54.

@LorenzoBettini
Copy link
Contributor Author

@cdietrich I've updated the PR version range in the MANIFEST, unpinned the version from TP, and updated the dependabot configuration according to my understanding of it.

@cdietrich
Copy link
Member

I guess we can try and revert if it misbehaves
Don’t know if there is a way to do it on a branch

@LorenzoBettini LorenzoBettini merged commit da32ee5 into main Sep 18, 2024
13 of 14 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_3199 branch September 18, 2024 16:49
@LorenzoBettini
Copy link
Contributor Author

@cdietrich I merged and looks like it's working as expected (https://github.com/eclipse/xtext/actions/runs/10926606231/job/30330860901):

2024/09/18 16:49:53 INFO <job_887152119> Checking all dependencies for version updates...
updater | 2024/09/18 16:49:53 INFO <job_887152119> Checking if io.github.classgraph:classgraph 4.8.176 needs updating
  proxy | 2024/09/18 16:49:54 [012] GET [https://repo.maven.apache.org:443/maven2/io/github/classgraph/classgraph/maven-metadata.xml](https://repo.maven.apache.org/maven2/io/github/classgraph/classgraph/maven-metadata.xml)
  proxy | 2024/09/18 16:49:54 [012] 200 [https://repo.maven.apache.org:443/maven2/io/github/classgraph/classgraph/maven-metadata.xml](https://repo.maven.apache.org/maven2/io/github/classgraph/classgraph/maven-metadata.xml)
updater | 2024/09/18 16:49:54 INFO <job_887152119> Filtered out 2 pre-release versions
  proxy | 2024/09/18 16:[49](https://github.com/eclipse/xtext/actions/runs/10926606231/job/30330860901#step:3:51):54 [016] HEAD https://repo.maven.apache.org:443/maven2/io/github/classgraph/classgraph/4.8.176/classgraph-4.8.176.jar
  proxy | 2024/09/18 16:49:54 [016] 200 [https://repo.maven.apache.org:443/maven2/io/github/classgraph/classgraph/4.8.176/classgraph-4.8.176.jar](https://repo.maven.apache.org/maven2/io/github/classgraph/classgraph/4.8.176/classgraph-4.8.176.jar)
updater | 2024/09/18 16:49:54 INFO <job_887152119> Latest version is 4.8.176
updater | 2024/09/18 16:49:54 INFO <job_8871[52](https://github.com/eclipse/xtext/actions/runs/10926606231/job/30330860901#step:3:54)119> No update needed for io.github.classgraph:classgraph 4.8.176

That's the only Maven artifact mentioned in the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classgraph version bump
2 participants