Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to orbit 2024-12 #3197

Merged
merged 1 commit into from
Sep 17, 2024
Merged

update to orbit 2024-12 #3197

merged 1 commit into from
Sep 17, 2024

Conversation

cdietrich
Copy link
Member

No description provided.

Signed-off-by: Christian Dietrich <[email protected]>
Copy link

Test Results

  6 460 files  ±0    6 460 suites  ±0   3h 15m 13s ⏱️ - 7m 56s
 43 242 tests ±0   42 658 ✅ ±0    584 💤 ±0   0 ❌ ±0 
170 113 runs  +4  167 740 ✅ ±0  2 358 💤 ±0  15 ❌ +4 

Results for commit ed99074. ± Comparison against base commit 643087f.

Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to increment the sequenceNumber but that's fine.

For the future, I think it is crucial to update the sequenceNumber at least in the latest target file, to be sure that Oomph or locally the target platform gets updated when pulling from Git repository.

@cdietrich
Copy link
Member Author

@LorenzoBettini i gave up on this. oomph forgets my tp each day anyway

@cdietrich cdietrich merged commit 44d7164 into main Sep 17, 2024
14 checks passed
@cdietrich cdietrich deleted the cd-orbit-202412 branch September 17, 2024 11:55
@LorenzoBettini
Copy link
Contributor

@LorenzoBettini i gave up on this. oomph forgets my tp each day anyway

What do you mean by "forget"?
However, I was talking more about the situation where one pulls from Git, not necessarily Oomph.
When you pull from Git and the sequence number of the current TP is increased, PDE should realize that it has to update the TP. Or maybe I'm wrong, cc @HannesWell.

@cdietrich
Copy link
Member Author

basically everytimei come back to the xtext dev env there is a ton of errors due target platform and i have to reoomph

@LorenzoBettini
Copy link
Contributor

If the errors are due to the tp, I'd suggest you simply open the .target file, let it resolve, and then choose Reload. Of course, this will trigger a rebuild.

Unless, you want to update the IDE, the above operation is faster than re-oomph. At least, in my experience.

@cdietrich
Copy link
Member Author

yes i do execute the "execute setup" all the time. and this is tedious. but i have no idea what causes it

@HannesWell
Copy link
Member

However, I was talking more about the situation where one pulls from Git, not necessarily Oomph.
When you pull from Git and the sequence number of the current TP is increased, PDE should realize that it has to update the TP. Or maybe I'm wrong, cc @HannesWell.

You are absolutely right. There are many things in the Target Editor respectively the TP handling that should be improved in PDE. It's on my list, but I haven't had the time yet to do it.

If I understand your case correctly one workaround is to first open the target file using the default target editor, wait until it is resolved and then run the Oomph setup.
It's not good that this is necessary, but at least it was a working workaround in my cases, e.g. the Eclipse SDK target is updated and I subsequently run the Oomph setup that includes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants