Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#522] Update to Hono 2.5.0 #523

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[#522] Update to Hono 2.5.0 #523

merged 2 commits into from
Feb 12, 2024

Conversation

sophokles73
Copy link
Member

Changed configuration to run Apache Kafka in KRaft mode.

Fixes #522

@sophokles73 sophokles73 force-pushed the update_to_hono_2.5.0 branch 8 times, most recently from eb58ba2 to 532a138 Compare January 28, 2024 19:09
@sophokles73
Copy link
Member Author

@calohmn Would you mind taking a look?

charts/hono/Chart.yaml Outdated Show resolved Hide resolved
charts/hono/values.yaml Outdated Show resolved Hide resolved
@calohmn
Copy link
Contributor

calohmn commented Jan 30, 2024

I think it would be good to also add support for the new useLegacyTraceContextFormat property in the new chart version.
I've created #524 for that (to be merged in this PR branch).

@sophokles73
Copy link
Member Author

sounds good, I will do that 👍

@sophokles73
Copy link
Member Author

@calohmn would you mind taking another look?

@calohmn
Copy link
Contributor

calohmn commented Feb 4, 2024

The Kafka chart update allows us to update the MongoDB chart again - see #490.
I think we could at least use the MongoDB chart version ^13.x again (undoing the change from #491).

@sophokles73
Copy link
Member Author

@calohmn I have changed the MongoDB dependency ...

@sophokles73
Copy link
Member Author

@calohmn I will now squash this into two commits and then we're good to go, right?

@sophokles73 sophokles73 reopened this Feb 12, 2024
sophokles73 and others added 2 commits February 12, 2024 09:40
Changed configuration to run Apache Kafka in KRaft mode.
Updated to latest bitnami MongoDB chart version 13.x.
Copy link
Contributor

@calohmn calohmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophokles73 yes, LGTM.

@sophokles73 sophokles73 merged commit 873b34b into master Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Hono 2.5.0
2 participants