Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#512] Add service account for Hono adapter pods; update tracing image versions. #509

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Sep 22, 2023

This fixes #512.
Apply changes needed for eclipse-hono/hono#3546, adding corresponding service accounts.

Also update jaegertracing/all-in-one and opentelemetry-collector image versions and fix Hono chart icon URL.

Service Account having role binding to 'get' 'pods'
- needed to query the container id via the K8s API (Hono #3537).
@calohmn calohmn changed the title Add service account for Hono adapter pods. [#512] Add service account for Hono adapter pods; update tracing image versions. Oct 8, 2023
@calohmn calohmn marked this pull request as ready for review October 8, 2023 09:15
Copy link
Member

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calohmn calohmn merged commit bf3a4fd into eclipse:master Oct 9, 2023
11 checks passed
@calohmn calohmn deleted the PR/hono_adapter_sa branch October 9, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set service account on Hono protocol adapter pods
2 participants