Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scriptlet required dependeny flags #67

Merged

Conversation

moedan
Copy link
Contributor

@moedan moedan commented Sep 10, 2024

PR as mentioned in #66 (comment) and #66 (comment)

  • Remove 2nd required dependency entry added by scriptlet setter
  • Add required dependency rpmlib(BuiltinLuaScripts) for lua scriptles only with flags LESS, EQUAL, RPMLIB

@ctron ctron merged commit 68949d0 into eclipse:master Sep 10, 2024
4 checks passed
@ctron
Copy link
Contributor

ctron commented Sep 10, 2024

Just to be clear, this makes it a breaking change. Which is fine, but we need to release it as such. Maybe even the first PR was, but this one is for sure.

@moedan
Copy link
Contributor Author

moedan commented Sep 10, 2024

Thanks a lot for the merge and your support! 👍

@ctron
Copy link
Contributor

ctron commented Sep 10, 2024

Thanks a lot for the work! And figuring it out.

Ready for a release?

@moedan
Copy link
Contributor Author

moedan commented Sep 10, 2024

I have tested this version of packager with your rpm-builder-plugin and it seems to be working as expected. So I think it is ready for release. 👍

@ctron
Copy link
Contributor

ctron commented Sep 10, 2024

Released both packager and rpm-builder (1.13.0). I'd appreciate if you could give it a try.

@moedan
Copy link
Contributor Author

moedan commented Sep 11, 2024

I can confirm that shell and lua scriptlets work as expected with rpm-builder in version 1.13.0. Thanks again! 👍

@ctron
Copy link
Contributor

ctron commented Sep 11, 2024

Thanks for the great work and the patience. And, for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants