Performance update #22

klausschuch · 2024-09-03T17:58:06Z

several improvements to increase simulation speed (memory layout, pre-allocation, ...)

The callback will be called after a component do-step, AFTER the out channels were updated via ComponentUpdateOutChannels (and implicitly via comp->UpdateOutChannels)

…r infos

…ents

src/components/comp_constant.c

+    }
+
+    if (i >= numVecOut) {
+        ComponentLog(comp, LOG_ERROR, "GetValue: Invalid index (%d) provided", idx);


src/core/Databus.c

+
+            retVal = dbInfos->PushBack(dbInfos, info);
+            if (RETURN_OK != retVal) {
+                mcx_log(LOG_ERROR, "Ports: Read port infos: Could not append info of port %d", i);


src/core/Databus.c

            if (RETURN_ERROR == retVal) {
-                mcx_log(LOG_ERROR, "Ports: Read port infos: Could not read element specific data of port %d", i);
+                mcx_log(LOG_ERROR, "Ports: Read port infos: Could not add vector info of port %d", i);


src/core/Databus.c

+            if (infos->Size(infos) == 1 && SpecificRead) {
+                retVal = SpecificRead(comp, infoCpy, portInput, i);
+                if (RETURN_ERROR == retVal) {
+                    mcx_log(LOG_ERROR, "Ports: Read port infos: Could not read element specific data of port %d", i);


src/core/Model.c

            && !channel->IsValid(channel)) {
            mcx_log(LOG_ERROR, "Model: %d. inport (%s) of element %s not connected"
-                , i+1, info->GetName(info), comp->GetName(comp));
+                , i+1, ChannelInfoGetName(info), comp->GetName(comp));


src/core/Model.c

            && !channel->IsValid(channel)) {
            mcx_log(LOG_ERROR, "Model: %d. outport (%s) of element %s not connected"
-                , i+1, info->GetName(info), comp->GetName(comp));
+                , i+1, ChannelInfoGetName(info), comp->GetName(comp));


src/core/SubModel.c

+    for (i = 0; i < comps->Size(comps); i++) {
+        Component * iComp = (Component *) comps->At(comps, i);
+        if (!iComp) {
+            mcx_log(LOG_DEBUG, "Model: nullptr in submodel at idx %d", i);


Vaan5 and others added 30 commits July 11, 2024 10:42

Fix whitespaces

ef19637

Add capacity to ObjectContainer

0666de9

Use ObjectContainerResize in ObjectContainerPushBack

b15a6e8

Use size within ObjectContainer directly

6cf1173

Add ObjectList

ef60f7b

Use ObjectList instead of ObjectContainer

03a2379

Use size variable

5ebc0bd

Cache ConnectionInfo type

6cd90eb

Adapt coding style

8b5cc36

Remove size check in ObjectList/Container Resize

a80e917

Fix TypeConversionConvertBoolDouble

1433851

time: Add mcx_time_to_micro_s function

9acf45b

Add calcStart/EndWallClockTime to rt factor results

7ea9280

rtFactor: Use a more consistent naming

34c8bee

Add ComponentBeforeDoSteps()

e121150

Use rtGlobalSimStart as reference for rtCalcStart and rtCalcEnd

fc70701

component: Restructue ComponentSetupRTFactor

48c2dbb

component: Reuse rtData->rtTotalSum_s

dd5da10

Set rtData.rtCompStart in ComponentBeforeDoSteps()

0cac58a

Component post do-step hook

4c34594

The callback will be called after a component do-step, AFTER the out channels were updated via ComponentUpdateOutChannels (and implicitly via comp->UpdateOutChannels)

Do not get FMU values in Fmu2DoStep()

11052c6

Add retrieval of observables to components (+submodels)

5839809

Rename Monitoring to Observable

129f788

Add STORE_MICRO store level

53eeda6

Databus: Track connected inputs

f0f3b71

Update connected inputs

a1e57a2

Add function to trigger only connected inputs

4d00f15

Trigger only connected inputs in steptypes

5653e8c

Component: Remove redundant ComponentUpdateOutChannels() call

0dc4ac7

Move DatabusUpdateInConnected() call to ModelConnectionsDone()

ca44ee0

Vaan5 and others added 29 commits July 11, 2024 10:47

Change time format in log file header

7ea746b

Fix const warnings regarding ChannelValue

cae9ce6

Convert path to a normalized absolute path prior to _waccess call

1630ee5

Implement a memory filter

118cb96

Forward correct argument to CompPostDoUpdateState

be4a159

Use the MemoryFilter when possible

0224c67

Add a switch to disable the MemoryFilter on demand

e291799

Check for cycles when determining the buffer size

89d3a9c

Use >= to check for buffer overflow

51d02a2

Use SIZE_MAX instead of MEM_FILTER_IDX_FLAG

1c95704

Print user's input as a string instead of the converted int value

a7631c1

Fix compiler warnings

80aa0c3

Define a Vector of pure C objects

254d521

Inline ConnectionInfo into the Connection

2702ae2

Remove ConnectionData

a84098a

Vector: Add SetAt method

836e97d

Vector: Hide Resize and expose a Reserve method

563936e

Inline ChannelInfo into the Channel

edd73e6

Drop ChannelData

8dc290f

Inline Channel::GetInfo

5448247

Vector optimizations

27a29e0

Remove unused variables

b5c256b

Move variables closer to the place where they are used

f8bb70f

Simplify ResultStorage

5854fa6

Check that the Databus channels were set before trying to update thei…

1ef31f4

…r infos

Define a ContainsComponent method

bdb8500

Submodel utility to properly check container-like components

35259ba

Make sure ComponentStorage->Finished is called for comp_solver compon…

0727977

…ents

common_fmu2: Add Fmi2TypeToString() function

e08d0dd

github-advanced-security bot found potential problems Sep 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Performance update #22

Performance update #22

klausschuch commented Sep 3, 2024

Performance update #22

Are you sure you want to change the base?

Performance update #22

Conversation

klausschuch commented Sep 3, 2024