Port openmcx to macOS #18
Conversation
robincaloudis
changed the title
`__mcx_dll_load()` makes use of the function `dlopen()`, which has a flag parameter. On Linux one uses `RTLD_DEEPBIND` to ensure that a library uses its own symbols rather than those provided by other loaded libraries. On MacOS there is not a direct equivalent available. Signed-off-by: Robin Caloudis <[email protected]>
Signed-off-by: Robin Caloudis <[email protected]>
Signed-off-by: Robin Caloudis <[email protected]>
Signed-off-by: Robin Caloudis <[email protected]>
Signed-off-by: Robin Caloudis <[email protected]>
When openmcx gets compiled on a Apple machine, it requires two additional headers to be present. My assumption is that these headers find its way into the compilation unit transitively on Linux and Windows machines, which they do not on Apple machines. Signed-off-by: Robin Caloudis <[email protected]>
robincaloudis
force-pushed
the
rc-apple
branch
from
a3d5983 to
339f1f8
Compare
robincaloudis
changed the title
robincaloudis
force-pushed
the
rc-apple
branch
2 times, most recently
from
22c0c30 to
5262e95
Compare
|
Hi, I'm working porting a Linux specific repo to MacOs Catalina. I have some queries on it. Is it possible to reach out to you on dm and have a discussion on the same. Apologise as the message is not relevant to this posting. |
|
Hi @Kamal-Nabhan-mcw, sure. You can reach me via my mail |
src/objects/ObjectContainer.c
Outdated
| const void *second) { | ||
| #else | ||
| static int ObjectContainerElementCmp(const void * first, const void * second, | ||
| void * ctx) { |
There was a problem hiding this comment.
The indentation contains spaces and tabs. Please just use spaces.
There was a problem hiding this comment.
Totally right. Messed up my editor configs. Corrected it. Thank you.
| #if(__APPLE__) | ||
| void mcx_sort(void *base, size_t nmemb, size_t size, | ||
| int (*compar)(void *, const void *, const void *), void *arg); | ||
| #else |
There was a problem hiding this comment.
Strange that the arg argument comes first in the apple implementation. We should add a comment to the source code to point this out.
Signed-off-by: Robin Caloudis <[email protected]>
robincaloudis
force-pushed
the
rc-apple
branch
from
5262e95 to
05df465
Compare
robincaloudis
force-pushed
the
rc-apple
branch
from
05df465 to
7edbe23
Compare
There was a problem hiding this comment.
@klausschuch, thanks for your review! Fixed all of your mentioned concerns. Please re-review.
| #if(__APPLE__) | ||
| void mcx_sort(void *base, size_t nmemb, size_t size, | ||
| int (*compar)(void *, const void *, const void *), void *arg); | ||
| #else |
src/objects/ObjectContainer.c
Outdated
| const void *second) { | ||
| #else | ||
| static int ObjectContainerElementCmp(const void * first, const void * second, | ||
| void * ctx) { |
There was a problem hiding this comment.
Totally right. Messed up my editor configs. Corrected it. Thank you.
Why
Currently, openmcx cannot be build on a macOS machine due to platform-specific code.
What
linuxtounixif underlying source code is common to Linux and macOS/examplesTested on Apple Silicon M2.