-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua bindings #527
base: master
Are you sure you want to change the base?
Lua bindings #527
Conversation
@@ -20,3 +21,17 @@ package.json | |||
binding.gyp | |||
READMEFIRST | |||
npm-debug.log | |||
|
|||
# lua files | |||
src/lua/mraaLUA_wrap.cxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kind of confused why all these are needed, if you use a build/ directory then everything will get ignored. Let's keep this stuff out unless there's a good reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not use build/ directory :)
Okay if you don't like these changes I can remove them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
building in tree is not recommended for cmake (or any other builds really tbh), any good reason why you can't just build somewhere outside of git or simply add an ignore for your build directory? In any case such stuff doesn't belong in commits adding Lua support so please remove.
So this is very cool, thanks. I'm worried there's alot of docs duplication, do the docs build? Also can you rebase all the patches into one and add a sign-off as mentioned in CONTRIBUTING.MD. Note, do the gpio interupts work? Any plans to support them? |
Only AIO, GPIO's read_, write_ is tested.
If some thing does not work I'll fix this. Currently I do not test all features since I need only GPIO read, write and AIO. But in the future my projects will need more MRAA features. |
Yes I did and I got few warnings, I do not have big knowledge in sphx docs :)
Only tomorrow. |
I found some issues in docs - I trying to resolve them. |
Hows this going Dedok? |
@Hbrinj Hi, in progress... |
No it's not critical just wanted to see if things were going well :) Sent from my iPhone
|
Any news on this? I'd love to merge an updated version of it |
Can somebody please merge this one? It's been here for months, and it is super-useful feature. |
Sorry I forgot about it. I have to revert all changes in docs generating and merge changes from my fork after that it could be merged. Current, this fork have few bugs. Please give me more time. |
@dedok, so do you still plan to get this one updated? |
Issue: #392
Also, when this PR is approved, I'll post some information about this event in lua, luajit, tarantool mailings.