Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Helidon releases; add SE 17 info along the way #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjquinno
Copy link
Contributor

Resolves #478

  1. Add JDK 17 as a Java version.
  2. Update which Helidon releases support which MP releases.

@tjquinno
Copy link
Contributor Author

@Karm When you can, please take a look. Thanks in advance.

@tjquinno
Copy link
Contributor Author

Looking into the test failures.

@tjquinno
Copy link
Contributor Author

@Karm It looks as if my PR does not completely enable the use of Java 17 where needed. My local testing fails when Maven rejects 17 as a choice.

I know @Emily-Jiang mentioned that support for 17 would be added. Maybe I should let the professionals take care of that in a separate PR and then I can present this one again.

Or, if you want to coach me as to what other changes I should add to this one, I'd be happy to do that too. Whoever is easier for you.

@Emily-Jiang
Copy link
Member

@tjquinno can you separate your PR to 2 parts? One PR is to update Helidon while the other one is to add Java 17.

@tjquinno
Copy link
Contributor Author

Hi, @Emily-Jiang. As I noted in my earlier comment, these changes are not sufficient for adding Java 17 support. Someone more knowledgeable than I will need to do that part. Then I am happy to modify this PR to address just the Helidon-specific changes.

@Emily-Jiang
Copy link
Member

Hi, @Emily-Jiang. As I noted in my earlier comment, these changes are not sufficient for adding Java 17 support. Someone more knowledgeable than I will need to do that part. Then I am happy to modify this PR to address just the Helidon-specific changes.

thanks @tjquinno ! Just rework your PR to add Helidon and we will add Java 17 under a different PR. @Karm Would you like to take a look at adding Java 17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Helidon versions used
2 participants