Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify specification text for CDI support #382

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

manovotn
Copy link
Contributor

Fixes #381

See linked issue for detailed explanation.
In short, The @RestClient qualifier is not optional and its presence is there to make sure rest client beans don't clash (and cause ambig. dependency resolution) with any other CDI bean with the same type.

This isn't changing current behavior, it is merely a removal of an incorrect explanation of CDI resolution rules.

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @manovotn

@Emily-Jiang Emily-Jiang merged commit 8e48b96 into eclipse:main Jun 17, 2024
8 checks passed
@manovotn manovotn deleted the cdiIntegrationCorrection branch June 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify specification text for CDI support
2 participants