Skip to content

Commit

Permalink
Merge pull request #373 from jamezp/fix-ci
Browse files Browse the repository at this point in the history
Use the correct paths to trigger CI.
  • Loading branch information
Emily-Jiang authored Jun 7, 2024
2 parents 36f1319 + 5312799 commit 78693d7
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 19 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,20 @@ on:
branches-ignore:
- 'dependabot/**'
paths:
- '.github/workflows/maven.yml'
- '**/pom.xml'
- 'api'
- 'spec'
- 'tck'
- 'api/**'
- 'spec/**'
- 'tck/**'
pull_request:
branches:
- '**'
paths:
- '.github/workflows/maven.yml'
- '**/pom.xml'
- 'api'
- 'spec'
- 'tck'
- 'api/**'
- 'spec/**'
- 'tck/**'

# Only run the latest job
concurrency:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@

package org.eclipse.microprofile.rest.client.tck.cditests;

import jakarta.enterprise.context.spi.CreationalContext;
import jakarta.enterprise.inject.spi.Bean;
import jakarta.enterprise.inject.spi.BeanManager;
import jakarta.inject.Inject;
import jakarta.ws.rs.ApplicationPath;
import jakarta.ws.rs.core.Application;
import org.eclipse.microprofile.rest.client.inject.RestClient;
import org.eclipse.microprofile.rest.client.tck.interfaces.cdi.scoped.AutoCloseableClient;
import org.eclipse.microprofile.rest.client.tck.interfaces.cdi.scoped.CloseableClient;
Expand All @@ -38,6 +32,13 @@
import org.testng.Assert;
import org.testng.annotations.Test;

import jakarta.enterprise.context.spi.CreationalContext;
import jakarta.enterprise.inject.spi.Bean;
import jakarta.enterprise.inject.spi.BeanManager;
import jakarta.inject.Inject;
import jakarta.ws.rs.ApplicationPath;
import jakarta.ws.rs.core.Application;

/**
* Tests that clients are closed when destroyed by the CDI container.
*
Expand All @@ -48,9 +49,9 @@ public class ClientClosedTest extends Arquillian {
@Deployment
public static Archive<?> createDeployment() {
return ShrinkWrap.create(WebArchive.class, ClientClosedTest.class.getSimpleName() + ".war")
.addClasses(ReturnWith200RequestFilter.class, AutoCloseableClient.class,
CloseableClient.class, StringClient.class, RestActivator.class)
.addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml");
.addClasses(ReturnWith200RequestFilter.class, AutoCloseableClient.class,
CloseableClient.class, StringClient.class, RestActivator.class)
.addAsManifestResource(EmptyAsset.INSTANCE, "beans.xml");
}

@Inject
Expand Down Expand Up @@ -91,7 +92,7 @@ private <T extends StringClient> void checkClient(final Class<T> type) {
resolved.destroy(client, ctx);
// The bean has been destroyed, expect an IllegalStateException if the method is invoked per the specification
Assert.expectThrows("Expected an IllegalStateException to be thrown", IllegalStateException.class,
client::executeGet);
client::executeGet);
}

@SuppressWarnings("unchecked")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@

package org.eclipse.microprofile.rest.client.tck.interfaces.cdi.scoped;

import jakarta.ws.rs.Path;
import org.eclipse.microprofile.rest.client.annotation.RegisterProvider;
import org.eclipse.microprofile.rest.client.inject.RegisterRestClient;

import jakarta.ws.rs.Path;

@Path("/")
// The host/port is hard-coded here as it is not currently used. The StringClientRequestFilter is used to abort the
// request with a 200 response code.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@

package org.eclipse.microprofile.rest.client.tck.interfaces.cdi.scoped;

import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import org.eclipse.microprofile.rest.client.annotation.RegisterProvider;
import org.eclipse.microprofile.rest.client.inject.RegisterRestClient;

import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;

/**
* @author <a href="mailto:[email protected]">James R. Perkins</a>
*/
Expand Down

0 comments on commit 78693d7

Please sign in to comment.