Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature error and minor grammar fixes #161

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/src/main/asciidoc/architecture.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ _Plain_ messages are created using:

* `org.eclipse.microprofile.reactive.messaging.Message#of(T)` - wraps the given payload, no acknowledgement
* `org.eclipse.microprofile.reactive.messaging.Message#of(T, java.util.function.Supplier<java.util.concurrent.CompletionStage<java.lang.Void>>)` - wraps the given payload and provides the acknowledgment logic
* `org.eclipse.microprofile.reactive.messaging.Message#of(Supplier<CompletionStage<Void>> ack, Function<Throwable, CompletionStage<Void>> nack)` - wraps the given payload and provides the acknowledgment and negative acknowledgment logic
* `org.eclipse.microprofile.reactive.messaging.Message#of(T, Supplier<CompletionStage<Void>> ack, Function<Throwable, CompletionStage<Void>> nack)` - wraps the given payload and provides the acknowledgment and negative acknowledgment logic


You can also create new `Message` instances by copying the content from an original message using the `withX` methods:
Expand Down Expand Up @@ -186,7 +186,7 @@ This mapping is configured in the application configuration.
Note that an implementation may provide various ways to configure the mapping, but support for MicroProfile Config as a configuration source is mandatory.

Connector implementations are associated with a name corresponding to a messaging transport, such as Apache Kafka, Amazon Kinesis, RabbitMQ or Apache ActiveMQ.
For instance, an hypothetical Kafka connector could be associated with the following name: `acme.kafka`.
For instance, a hypothetical Kafka connector could be associated with the following name: `acme.kafka`.
This name is indicated using a qualifier on the connector implementation.

The user can associate a channel with this connector using the associated name:
Expand Down Expand Up @@ -265,7 +265,7 @@ Also the method must be implemented in a non-blocking fashion.
For blocking transformations, asynchronous variants can be used.

NOTE: _assembly_ time is when the Reactive Messaging implementation initializes itself and creates the different bean instances and connects them together.
If the implementation cannot find a incoming of outgoing channel, a `DeploymentException` must be thrown when the application starts.
If the implementation cannot find an incoming for an outgoing channel, a `DeploymentException` must be thrown when the application starts.

NOTE: In the following lists, `Message` can be an implementation of the `Message` interface.

Expand Down