Make config disabled tests use AsyncTaskManager
#633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azquelt
force-pushed
the
config-tests-executor
branch
from
3c288d8 to
a05c396
Compare
Azquelt
changed the title
Azquelt
force-pushed
the
config-tests-executor
branch
from
a05c396 to
3f0c9b7
Compare
Azquelt
changed the title
AsyncTaskManager
Azquelt
force-pushed
the
config-tests-executor
branch
from
3f0c9b7 to
e25f8c2
Compare
Previously these tests were using a fixed thread pool executor which will create unmanaged threads on a Jakarta EE server.
Azquelt
force-pushed
the
config-tests-executor
branch
from
e25f8c2 to
46d2da8
Compare
Emily-Jiang
approved these changes
Jun 26, 2024
|
@Azquelt can you also add this to the release note in the spec doc? |
|
I've updated the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these tests were using a fixed thread pool executor which will create unmanaged threads on a Jakarta EE server.
We already have
AsyncCallerwhich is designed to avoid this, andAsyncTaskManagerwhich provides additional framework for exactly these type of tests so we should use them here.Unfortunately these test classes are also testing the disablement of the
@Asynchronousannotation whichAsyncCallerandAsyncTaskManageruse. We could split these tests up, but it's easier to add additional config to enable the annotation for that class specifically.Fixes #634