This PR replaces all expected RuntimeExceptions with TestException. T… #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
benjamin-confino
force-pushed
the
master
branch
from
6553be5 to
19fee51
Compare
|
I think instances like this should also be updated: https://github.com/eclipse/microprofile-fault-tolerance/pull/619/files#diff-75e65464c0fe1fb4456a2b1d045d03b43dbc7ed637603883d5f8292dccdd5b07L102 This test should expect a TestException on iteration 1,2,3,7,8 and 9. It should fail with a different error (in the surrounding catch block) if another exception is thrown. |
…his is because I saw some genuine RuntimeExceptions causing failures in our build system and if runtime exceptions can appear where they are not expected the wrong runtime exception may appear where a runtime exception is expected
benjamin-confino
force-pushed
the
master
branch
from
19fee51 to
c1dbb71
Compare
Azquelt
reviewed
Feb 12, 2024
tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/AsyncTimeoutTest.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 12, 2024
...file/fault/tolerance/tck/circuitbreaker/clientserver/CircuitBreakerClientWithRetryAsync.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 13, 2024
tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/FallbackTest.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 13, 2024
tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/FallbackTest.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 15, 2024
...clipse/microprofile/fault/tolerance/tck/retry/clientserver/RetryClassLevelClientAbortOn.java
Show resolved
Hide resolved
Azquelt
reviewed
Feb 15, 2024
tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/RetryConditionTest.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 19, 2024
.../java/org/eclipse/microprofile/fault/tolerance/tck/visibility/retry/RetryVisibilityTest.java
Outdated
Show resolved
Hide resolved
Azquelt
reviewed
Feb 19, 2024
.../java/org/eclipse/microprofile/fault/tolerance/tck/visibility/retry/RetryVisibilityTest.java
Show resolved
Hide resolved
Azquelt
reviewed
Feb 20, 2024
.../java/org/eclipse/microprofile/fault/tolerance/tck/visibility/retry/RetryVisibilityTest.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
master
branch
3 times, most recently
from
08e46c5 to
12dec1a
Compare
benjamin-confino
force-pushed
the
master
branch
from
12dec1a to
f297f33
Compare
These are all changes that the autoformatter makes when running the build.
|
@eclipse-microprofile-bot test this please |
Azquelt
approved these changes
Feb 20, 2024
|
@eclipse-microprofile-bot test this please |
1 similar comment
|
@eclipse-microprofile-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…his is because I saw some genuine RuntimeExceptions causing failures in our build system and if runtime exceptions can appear where they are not expected the wrong runtime exception may appear where a runtime exception is expected
Where a runtime exception is not expected it also updates the error message to include the details of that exception
fixes #620