Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify optional integration with MicroProfile Context Propagation #565

Closed
wants to merge 4 commits into from
Closed

specify optional integration with MicroProfile Context Propagation #565

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d6d252
specify optional integration with MicroProfile Context Propagation
Ladicek Jun 30, 2020
be6adc2
apply suggestions from code review
Ladicek Jul 16, 2020
5d86138
add TCK test for MicroProfile Context Propagation integration
Ladicek Jul 16, 2020
7a5f97d
add a note about request context being active in presence of Context …
Ladicek Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions spec/src/main/asciidoc/optional-integrations.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,10 @@ However, there are configuration properties that you can use to override the def
====

If the environment that provides MicroProfile Context Propagation is itself a Jakarta EE container, the _Jakarta EE_ section above doesn't apply and context propagation is left entirely to MicroProfile Context Propagation.

[NOTE]
====
The _Asynchronous Usage_ chapter specifies that "context for `RequestScoped` must be active during the asynchronous method invocation".
When MicroProfile Context Propagation is used, this still applies.
The difference is that the request context will be not only active, but also propagated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The difference is that the request context will be not only active, but also propagated.
The difference is that the request context may be not only active, but also propagated.

Suggest changing "will" to "may" given that Context Propagation may be configured not to propagate the request context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had "(or cleared, depending on Context Propagation configuration)" at the end of the sentence. For some reason, I thought it's better to remove it :-)

====