On error validation #289
Open
On error validation #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAvi123
reviewed
Apr 15, 2022
|
|
||
| invalidParamsCheck(type, WebSocketConstants.ON_OPEN, WebSocketConstants.ON_OPEN_PARAM_OPT_TYPES, | ||
| WebSocketConstants.RAW_ON_OPEN_PARAM_OPT_TYPES, WebSocketConstants.DIAGNOSTIC_CODE_ON_OPEN_INVALID_PARAMS, | ||
| Collections.emptySet(), Collections.emptySet(), unit, diagnostics); |
There was a problem hiding this comment.
might be a bit more space-efficient to pass in null instead of empty sets here and then have a check in the function?
| Collections.emptySet(), Collections.emptySet(), unit, diagnostics); | ||
| invalidParamsCheck(type, WebSocketConstants.ON_CLOSE, WebSocketConstants.ON_CLOSE_PARAM_OPT_TYPES, | ||
| WebSocketConstants.RAW_ON_CLOSE_PARAM_OPT_TYPES, WebSocketConstants.DIAGNOSTIC_CODE_ON_CLOSE_INVALID_PARAMS, | ||
| Collections.emptySet(), Collections.emptySet(), unit, diagnostics); |
There was a problem hiding this comment.
same as above for empty sets
| Diagnostic diagnostic2 = createDiagnostic(genMandTypeCounter.get(genParamType), unit, | ||
| diagMsg, WebSocketConstants.DIAGNOSTIC_CODE_DUP_PARAMS_TYPES); | ||
| diagnostics.add(diagnostic2); | ||
| continue; |
giancarlopernudisegura
approved these changes
Apr 15, 2022
Comment on lines
+94
to
+95
| public static final Set<String> ON_ERROR_PARAM_OPT_TYPES = new HashSet<>(Arrays.asList("jakarta.websocket.Session")); | ||
| public static final Set<String> RAW_ON_ERROR_PARAM_OPT_TYPES = new HashSet<>(Arrays.asList("Session")); |
There was a problem hiding this comment.
I suspect if you pull the latest changes from main, you'll be able to use the defined strings for these hashsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #249