Fix HttpClientProxyCredentialProvider.getPasswordAuthentication #78
Conversation
Ensure that httpclientjava's HttpClientProxyCredentialProvider.getCredentials(AuthScope) is called with a correct AuthScope from getPasswordAuthentication. Also update some target platform dependencies for the 2022-03 target to use the most recently released versions of client5/core5. Focus particularly on what is required by the httpclient5 feature because that's pulled into p2 and hence almost all installations, e.g., it does not need to include org.apache.commons.logging and should use the latest org.apache.commons.commons-codec rather than org.apache.commons.codec. eclipse#76 eclipse#77
|
Can one of the admins verify this patch? |
|
FYI, I also did a test build in EMF's ci instance to produce this repository with signed content: This also lets me verify that with the above build, the Platform will be able to consume only the latest dependencies:
|
|
|
||
| <plugin | ||
| id="org.apache.commons.logging" | ||
| id="org.apache.commons.commons-codec" |
There was a problem hiding this comment.
Did org.apache.commons.logging get dropped on purpose here?
There was a problem hiding this comment.
Yes, because I checked and there are no requirements on this by any of the http5 stuff. I suspect it was just copied from the 4.x stuff. Here is SimRel after you contributed httpclient5:
Note the image from the previous comment resolves using planner mode, so if something actually required it, even only transitively, it would still be present in the target for that location...
There was a problem hiding this comment.
Thanks Ed for confirming.
|
I have merged this commit and built a new snapshot that includes it here: https://download.eclipse.org/rt/ecf/snapshot/site.p2/3.14.40.v20231114-1017 |
|
Hi Ed. Does this comment eclipse-equinox/p2#381 (comment) indicate that the fix for this issue doesn't work as desired? |
Indeed, it's not enough :( |
Ensure that httpclientjava's
HttpClientProxyCredentialProvider.getCredentials(AuthScope) is called with a correct AuthScope from getPasswordAuthentication.
Also update some target platform dependencies for the 2022-03 target to use the most recently released versions of client5/core5. Focus particularly on what is required by the httpclient5 feature because that's pulled into p2 and hence almost all installations, e.g., it does not need to include org.apache.commons.logging and should use the latest org.apache.commons.commons-codec rather than org.apache.commons.codec.
#76
#77