Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloe recipes: Fix ABI compatibility issues #251

Merged
merged 22 commits into from
Jul 26, 2024
Merged

Cloe recipes: Fix ABI compatibility issues #251

merged 22 commits into from
Jul 26, 2024

Conversation

fgguidi
Copy link

@fgguidi fgguidi commented Jul 22, 2024

  • Changes shall be released as Cloe v0.24.1.
  • Add full_package_mode() to dependencies. Conan configuration default parameter is semver_direct_mode. This means that only a package will be rebuilt when the consumer changes the package version to a newer major version. For example, if consumed nlohmann_json/3.11.2 is consumed by fable/, but the final application recipe overrides nlohmann_json/3.11.3, with the default Conan configuration, fable won't be rebuilt causing a runtime error due to ABI incompatibility. Most of the times the Conan configuration in a project is not under our control making it impossible to change this from the Conan configuration side. Hence, having the recipes with the mode that we want becomes important.
  • Fix shared option value for OSI and Protobuf when consumed in esmini conan package. The OSI.shared=True and protobuf.shared=False is set on purpose to avoid runtime issues with Protobuf with either WSL or Linux (different values will produce runtime issues).

@fgguidi fgguidi requested review from cassava and tobifalk as code owners July 22, 2024 14:52
@clsim clsim self-requested a review July 22, 2024 14:54
Franco Guidi added 21 commits July 23, 2024 15:48
engine: Set full_package_mode() for dependencies
56e451f 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
fable: Set full_package_mode() for dependencies
35a803d 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
models: Set full_package_mode() for dependencies
456150f 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
oak: Set full_package_mode() for dependencies
57e1011 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
optional/vtd: Set full_package_mode() for dependencies
44a083d 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
osi: Set full_package_mode() for dependencies
439ff8e 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/basic: Set full_package_mode() for dependencies
564f9ff 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/clothoid_fit: Set full_package_mode() for dependencies
f2651d5 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/esmini: Set full_package_mode() for dependencies
8600619 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/frustum_culling: Set full_package_mode() for dependencies
fe23929 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/gndtruth_extractor: Set full_package_mode() for dependencies
6d13a7e 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/minimator: Set full_package_mode() for dependencies
212635a 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/mocks: Set full_package_mode() for dependencies
d652af4 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/noisy_sensor: Set full_package_mode() for dependencies
e67c81d 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/speedometer: Set full_package_mode() for dependencies
f603c11 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
plugins/virtue: Set full_package_mode() for dependencies
ffa82b0 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
runtime: Set full_package_mode() for dependencies
fc1e7bd 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
vendor/esmini: Fix dependency configuration
4e4f3f3 
- Fix OSI to be shared=True and Protobuf to be shared=False. A different
  combination has demonstrated to be challenging/impossible to be
  integrated when both WSL and Linux are supported in the same project.
- Set full_package_mode to dependencies: The Conan configuration has as
  default semver_direct_mode. This means that from the final consumer
  recipe perspective if I override the version of a dependency package
  A from v1.0.0 to v1.0.1, any dependency that is also part of the
  dependency tree and is also consuming package A, will not be rebuilt
  because semver_direct_mode doesn't consider patch releases in the
  package_id of the consumer. We set full_package_mode to the
  dependencies to consider this case and the user, channel and
  package_id of the dependencies to define the resulting package_id of
  the consumer.
vendor/osi: Set full_package_mode() for dependencies
f804d62 
The Conan configuration has as default semver_direct_mode. This means
that from the final consumer recipe perspective if I override the
version of a dependency package A from v1.0.0 to v1.0.1, any dependency
that is also part of the dependency tree and is also consuming package
A, will not be rebuilt because semver_direct_mode doesn't consider patch
releases in the package_id of the consumer. We set full_package_mode to
the dependencies to consider this case and the user, channel and
package_id of the dependencies to define the resulting package_id of the
consumer.
tooling: Align dependencies with master branch
e06fdbb 
Align overrides in the master conanfile of the Cloe-eclipse project
to the same used in master branch (avoid unnecessary differences
with private packages which are produced with different versions of
Cloe).
docs: Add release notes for Cloe v0.24.1
45e12a4
@fgguidi fgguidi force-pushed the feature/add-strict-mode-to-recipe branch from 372a3c0 to 45e12a4 Compare July 23, 2024 14:38
@fgguidi fgguidi requested a review from scpa1055 as a code owner July 24, 2024 14:34
@fgguidi fgguidi force-pushed the feature/add-strict-mode-to-recipe branch from 7f75e52 to 7b4d1ac Compare July 25, 2024 13:53
@scpa1055 scpa1055 merged commit 3008b85 into eclipse:develop24_x Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clsim clsim clsim approved these changes

@CzBalti CzBalti CzBalti approved these changes

@cassava cassava Awaiting requested review from cassava cassava is a code owner

@tobifalk tobifalk Awaiting requested review from tobifalk tobifalk is a code owner

@scpa1055 scpa1055 Awaiting requested review from scpa1055 scpa1055 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgguidi @CzBalti @clsim @scpa1055