Provide access to the default redirect handler #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Oct 1, 2024
geoand
force-pushed
the
httpclient-default-redirect
branch
from
a4cbd17
to
913ef15
Compare
vietj
reviewed
Oct 1, 2024
vertx-core/src/main/java/io/vertx/core/http/HttpClientAgent.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Oct 1, 2024
vertx-core/src/main/java/io/vertx/core/http/DefaultRedirectHandler.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
httpclient-default-redirect
branch
from
913ef15
to
4f97976
Compare
|
PR updated as per review comments |
vietj
reviewed
Oct 2, 2024
vietj
reviewed
Oct 2, 2024
vertx-core/src/main/java/io/vertx/core/http/impl/DefaultRedirectHandler.java
Show resolved
Hide resolved
geoand
force-pushed
the
httpclient-default-redirect
branch
from
4f97976
to
94a6710
Compare
vietj
reviewed
Oct 2, 2024
vertx-core/src/main/java/io/vertx/core/http/HttpClientAgent.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
httpclient-default-redirect
branch
from
94a6710
to
b7bcb97
Compare
This is useful for building redirect handlers for clients that need to delegate to the default behavior. In Quarkus we will leverage this to get rid of the deprecated (and since removed) calls to redirectHandler
geoand
force-pushed
the
httpclient-default-redirect
branch
from
b7bcb97
to
62138e8
Compare
|
thanks @geoand |
|
🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is useful for building redirect handlers
for clients that need to delegate to the default behavior. In Quarkus we will leverage this to get rid of the deprecated (and since removed) calls to redirectHandler