Speedup HTTP headers lowercase transformation #5055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some simple HTTP 2 hello world benchmarks,
HttpUtils::toLowerCase
has pop-up due to how Quarkus handle HTTP headers using Jax-RS HTTP header name constants ie using capital letters inString
s eg "Content-Type".This is speeding up the
String
lowercase transformation case improving the others, where possible.baseline:
b2925a8 :
This change is kind-of related to https://github.com/quarkusio/quarkus/pull/37619/files#diff-7cd9e11ea75ab750663bd15870c0749df275c32fd3d8eb2dfdc8eb706e4db540L499
which, instead, try to address it by forcing to use the same
AsciiString
of vertx, but introducing some ugly APIs which doesn't fit with the rest.That's why I think that improving on Vertx side is more beneficial for this