Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 21 #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to Java 21 #28

wants to merge 1 commit into from

Conversation

PatrickTasse
Copy link
Contributor

No description provided.

@PatrickTasse
Upgrade to Java 21
ac2a54c 
Signed-off-by: Patrick Tasse <[email protected]>
bhufmann
bhufmann requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think we should build for java 8 JVM and just make sure that it works when running with newer JVMs. Otherwise only applications that use java 21 can use it.

MatthewKhouzam
MatthewKhouzam reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a lambda getThreadID() that uses reflection to get the right method, have it stored globally as GET_THREAD_ID or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewKhouzam MatthewKhouzam MatthewKhouzam left review comments

@bhufmann bhufmann bhufmann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickTasse @bhufmann @MatthewKhouzam