Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmf: Move bookmark toggle marker to the background #213

Conversation

kavehshahedi
Copy link
Contributor

What it does

This PR moves the bookmark toggle marker to the background by reordering its rendering. This change improves visualization and representation by preventing the marker from overlapping other UI elements, ensuring a cleaner and more intuitive display.

How to test

  1. Open a trace in Trace Compass.
  2. Add a bookmark to a specific event.
  3. Observe the placement of the bookmark toggle marker.
  4. Verify that the marker is correctly displayed in the background, without interfering with other visual elements.

Follow-ups

  • If any UI inconsistencies arise due to the reordering, additional refinements may be required.

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template.

The toggle marker is now moved to the background (re-ordering), for
better visualization and representation.

Signed-off-by: Kaveh Shahedi <[email protected]>
@kavehshahedi kavehshahedi force-pushed the timegraph-marker-foreground branch from a1d51fc to 1b4a355 Compare January 31, 2025 19:22
@kavehshahedi kavehshahedi deleted the timegraph-marker-foreground branch February 4, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant