tmf: remove unnecessary cast

[arfio]

This patch remove some casts that are showing as errors in eclipse.

I found two categories:

• Cast from children classes to parent classes: I removed those ones since they are not really needed.
• Cast after an instanceof check: It seems that in some recent version, the behaviour changed and these ones are sometimes classified as unnecessary. I found information on JEP 305 where that allows the following:

if (animal instanceof Cat cat)  {  
      out.println(cat.meow());  
}

However, in this case the following code indicates the cast as unnecessary:

IResource resource = getResource();
if (resource instanceof IFolder) {
    path = ((IFolder) resource).getFullPath();
}

IResource being a parent class of IFolder.
As I am not sure what really happens there, I have not made the change to remove those casts even though removing it seems to work.

[bhufmann]

Does this work with Java 11? We still support older Eclipse targets (e.g. 2021-06, e4.20) that builds with Java 11.

[arfio]

I seem to have no errors building this with java 11 and eclipse 2021-06, e4.20. However I have a couple of errors with this PR: #174 for the changes added to the CompositeHostModel.

[arfio]

After verifying the other cases, the compiler was right in identifying most of these as unnecessary because in every instance, the method called after casting was present in the parent class.

[bhufmann]

Looks good to me. Thanks.

[MatthewKhouzam]

Less code is a yes