Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmf: add jsonParameters to ITmfConfiguration and ITmfConfigurationSource #144

Closed

Conversation

bhufmann
Copy link
Contributor

@bhufmann bhufmann commented Sep 6, 2024

This PR includes changes of PR #141.

An additional commit is added:
tmf: add jsonParameters to ITmfConfiguration and ITmfConfigurationSource

This is as alternative to Map<String, Object>.

This is a compromise to not having to depend on a json parsing library in the ITmfConfiguration interface.

[Added] jsonParameters to ITmfConfiguration and ITmfConfigurationSource

Signed-off-by: Bernd Hufmann [email protected]

@bhufmann bhufmann changed the title Json schema json if Add API constant for retrieving json string from TmfConfiguration Sep 6, 2024
@bhufmann bhufmann force-pushed the json-schema-json-if branch 2 times, most recently from 3202beb to 653bbaf Compare September 18, 2024 21:39
For schema specification see https://json-schema.org/

[Added] support for json-schema file to TmfConfigurationSourceType

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann force-pushed the json-schema-json-if branch 3 times, most recently from 081e731 to 4da7c27 Compare September 23, 2024 20:57
@bhufmann bhufmann changed the title Add API constant for retrieving json string from TmfConfiguration tmf: add jsonParameters to ITmfConfiguration and ITmfConfigurationSource Sep 23, 2024
This is as alternative to Map<String, Object>.

[Added] jsonParameters to ITmfConfiguration and ITmfConfigurationSource

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann
Copy link
Contributor Author

Not needed anymore, because only Map<String, Object> was decided to be used (see here: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#88 (comment))

@bhufmann bhufmann closed this Oct 16, 2024
@bhufmann bhufmann mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant