fix: fix handling of URI variables #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
fix-uri-variables
branch
from
fdb9276
to
c332cbe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 52.33% 52.49% +0.16%
==========================================
Files 69 69
Lines 2188 2185 -3
==========================================
+ Hits 1145 1147 +2
+ Misses 1043 1038 -5 ☔ View full report in Codecov by Sentry. |
This currently a workaround that requires a proper reimplementation.
JKRhb
force-pushed
the
fix-uri-variables
branch
from
3c1a0b1
to
207b362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, URI variables have not been handled correctly, leading to an error if an "optional" URI variable was defined for an interaction afordance (i.e., no DataSchema was provided for its usage) and the value was provided for the URI variable in question.
This aspect needs to be revisited in later PRs (and better covered by tests), but for now, this PR makes it possible to interact with the node-wot counter example (again).