Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use base instead of interface for ProtocolClient class #168

Merged
merged 1 commit into from
May 29, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 29, 2024

As a step towards adding #167, this PR changes the class modifier of the ProtocolClient class from interface to class, making it possible to specify certain (discovery) functionalities via mixins.

As they alter the API of the core library, these are breaking changes.

@JKRhb JKRhb enabled auto-merge May 29, 2024 09:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (9e1ac1f) to head (26a8075).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   66.69%   66.74%   +0.05%     
==========================================
  Files          77       77              
  Lines        2438     2436       -2     
==========================================
  Hits         1626     1626              
+ Misses        812      810       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb merged commit a8aca0e into main May 29, 2024
5 checks passed
@JKRhb JKRhb deleted the protocol-client-base-class branch May 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants