Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App selection with image #356

Closed
wants to merge 20 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove image name from footer on selection
iyannsch committed Sep 23, 2024
commit f37a94d04a1aa1c38bdc655fef3306c2925331a4
2 changes: 1 addition & 1 deletion node/landing-page/src/App.tsx
Original file line number Diff line number Diff line change
@@ -267,7 +267,7 @@ function App(): JSX.Element {
title={config.infoTitle}
/>
)}
<Footer selectedAppDefinition={selectedAppDefinition} />
<Footer selectedAppDefinition={autoStart ? selectedAppDefinition : ''} />
</div>
</div>
);
10 changes: 6 additions & 4 deletions node/landing-page/src/components/Footer.tsx
Original file line number Diff line number Diff line change
@@ -4,10 +4,12 @@ interface FooterProps {

export const Footer = ({ selectedAppDefinition }: FooterProps): JSX.Element => (
<div className='App__footer'>
<p>
<label htmlFor='selectapp'> {selectedAppDefinition} </label>
</p>
<p></p>
{ selectedAppDefinition != '' && (
<p>
<label htmlFor='selectapp'> {selectedAppDefinition} </label>
</p>)
}

<p>
Having problems? Please{' '}
<a target='_blank' href='https://github.com/eclipsesource/theia-cloud/issues' rel='noreferrer'>