Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(projects): Improve project relationship iteration with VersionComparator #2963

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(projects): Improve project relationship iteration with VersionComparator #2963

wants to merge 4 commits into from
+41 −4

Conversation

Ankush1oo8
Copy link

Please provide a summary of your changes here.

  • Added VersionComparator in common/utils for accurate version sorting
  • Updated iterateProjectRelationShips methods to use VersionComparator
  • Improved sorting logic for project links based on name and version
  • Ensured compatibility with existing project relationship handling

Issue: #236

Suggest Reviewer

How To Test?

  1. Run the SW360 backend and verify project relationships are sorted correctly.
  2. Ensure no functionality is broken by running tests.
  3. Validate the sorting logic using different project versions.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 10, 2025
@Ankush1oo8 Ankush1oo8 force-pushed the feature/version-comparator-update branch from 001a785 to 0c40917 Compare March 11, 2025 12:04
@Ankush1oo8 Ankush1oo8 requested a review from GMishx March 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

@GMishx GMishx Awaiting requested review from GMishx GMishx is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs code review needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ankush1oo8 @GMishx