-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest) :New Rest end point for edit obligation #2935
base: main
Are you sure you want to change the base?
feat(rest) :New Rest end point for edit obligation #2935
Conversation
8b1c07b
to
dae42dc
Compare
dae42dc
to
c1ccecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed.
import com.google.common.collect.Lists; | ||
import com.google.common.collect.Sets; | ||
import com.ibm.cloud.cloudant.v1.Cloudant; | ||
import com.ibm.cloud.cloudant.v1.model.DocumentResult; | ||
import org.apache.commons.io.IOUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for changes in import for just adding the line
oblig.setRevision(oldObligation.getRevision());
It makes review hard. Please revert the unnecessary changes and adjust your IDE, which I assume made the changes for you :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bibhuti230185 any updates on the same?
...r/src/main/java/org/eclipse/sw360/rest/resourceserver/obligation/Sw360ObligationService.java
Outdated
Show resolved
Hide resolved
c1ccecd
to
387b82d
Compare
Signed-off-by: Bibhuti Bhusan Dash bibhuti230185 <[email protected]> Signed-off-by: Bibhuti Bhusan dash bibhuti230185 <[email protected]>
28c23b9
to
0db7641
Compare
Signed-off-by: Bibhuti Bhusan dash bibhuti230185 <[email protected]>
Issue:
Edit Page (N) #2797
Suggest Reviewer
@GMishx
How To Test?
Ensure the application is running.
Obtain valid authentication tokens for users with and without CLEARING_ADMIN authority.
Checklist
Must: