lint is perfomed from the root of the project

Unify eslint & tsconfig
eclipse-sprotty · Nov 7, 2023 · 4787ce3 · 4787ce3
1 parent 5c4476b
commit 4787ce3
Show file tree

Hide file tree

Showing 31 changed files with 325 additions and 314 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,9 +1,116 @@
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
-    extends: ['./configs/.eslintrc.js'],
-    ignorePatterns: ['**/{node_modules,lib}'],
+    env: {
+        browser: true,
+        node: true
+    },
+    extends: [
+        'prettier'
+    ],
+    parser: '@typescript-eslint/parser',
+    ignorePatterns: [
+        '**/{node_modules,lib}',
+        '**/sprotty-local-template/**/*'
+    ],
     parserOptions: {
         tsconfigRootDir: __dirname,
-        project: 'tsconfig.json'
+        project: './tsconfig.json'
+    },
+    plugins: [
+        'eslint-plugin-no-null',
+        '@typescript-eslint',
+        'header'
+    ],
+    rules: {
+        '@typescript-eslint/indent': 'off',
+        '@typescript-eslint/naming-convention': 'off',
+        '@typescript-eslint/no-dynamic-delete': 'error',
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-misused-new': 'error',
+        '@typescript-eslint/no-shadow': [
+            'warn',
+            {
+                'hoist': 'all'
+            }
+        ],
+        '@typescript-eslint/no-unused-expressions': 'off',
+        '@typescript-eslint/semi': [
+            'error',
+            'always'
+        ],
+        '@typescript-eslint/type-annotation-spacing': 'warn',
+        'header/header': ['error', 'block', [{'pattern': '[\n\r]+ \\* Copyright \\([cC]\\) \\d{4}(-\\d{4})? .*[\n\r]+'}]],
+        'brace-style': [
+            'warn',
+            '1tbs',
+            { 'allowSingleLine': true }
+        ],
+        'comma-dangle': ['warn', {
+            'arrays': 'only-multiline',
+            'objects': 'only-multiline',
+        }],
+        'constructor-super': 'error',
+        'curly': 'off',
+        'eol-last': 'warn',
+        'eqeqeq': [
+            'warn',
+            'smart'
+        ],
+        'guard-for-in': 'warn',
+        'id-blacklist': 'off',
+        'id-match': 'off',
+        'keyword-spacing': ['warn', { 'before': true }],
+        'max-len': [
+            'warn',
+            {
+                'code': 180
+            }
+        ],
+        'no-prototype-builtins': 'error',
+        'no-caller': 'error',
+        'no-console': 'off',
+        'no-debugger': 'warn',
+        'no-eval': 'error',
+        'no-fallthrough': 'warn',
+        'no-invalid-this': 'warn',
+        'no-new-wrappers': 'warn',
+        'no-null/no-null': 'off',
+        'no-redeclare': 'off',
+        'no-restricted-imports': [
+            'error',
+            '..',
+            '../index',
+            '../..',
+            '../../index'
+        ],
+        'no-return-await': 'warn',
+        'no-sequences': 'error',
+        'no-throw-literal': 'error',
+        'no-trailing-spaces': 'warn',
+        'no-underscore-dangle': 'off',
+        'no-unsafe-finally': 'error',
+        'no-var': 'error',
+        'prefer-const': [
+            'warn',
+            {
+                'destructuring': 'all'
+            }
+        ],
+        'prefer-object-spread': 'warn',
+        'radix': 'warn',
+        'spaced-comment': [
+            'warn',
+            'always',
+            {
+                'markers': [
+                    '/'
+                ],
+                'exceptions': [
+                    '*'
+                ]
+            }
+        ],
+        'space-infix-ops': 'warn',
+        'use-isnan': 'warn'
     }
-};
+};
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -22,5 +22,7 @@ jobs:
         node-version: '16'
     - name: Build
       run: yarn
+    - name: Lint
+      run: yarn lint
     - name: Test
       run: yarn test
diff --git a/configs/.eslintrc.js b/configs/.eslintrc.js
diff --git a/configs/base.tsconfig.json b/configs/base.tsconfig.json
diff --git a/examples/circlegraph/src/di.config.ts b/examples/circlegraph/src/di.config.ts
@@ -25,7 +25,7 @@ import { CircleNodeView } from './views';
 
 const NodeCreator = Symbol('NodeCreator');
 
-export default (nodeCreator: (point?: Point)=>void) => {
+export default (nodeCreator: (point?: Point) => void) => {
     require('sprotty/css/sprotty.css');
     require('../css/diagram.css');
 
@@ -58,15 +58,15 @@ export default (nodeCreator: (point?: Point)=>void) => {
 @injectable()
 class DroppableMouseListener extends MouseListener {
 
-    @inject(NodeCreator) nodeCreator: (point?: Point)=>void;
+    @inject(NodeCreator) nodeCreator: (point?: Point) => void;
 
     override dragOver(target: SModelElementImpl, event: MouseEvent): (Action | Promise<Action>)[] {
         event.preventDefault();
         return [];
     }
 
     override drop(target: SModelElementImpl, event: MouseEvent): (Action | Promise<Action>)[] {
-        this.nodeCreator({ x: event.offsetX, y:event.offsetY })
+        this.nodeCreator({ x: event.offsetX, y:event.offsetY });
         return [];
     }
 }

diff --git a/examples/circlegraph/src/standalone.ts b/examples/circlegraph/src/standalone.ts
@@ -83,10 +83,10 @@ export default async function runCircleGraph() {
     async function createNode(point?: Point) {
         const viewport = await modelSource.getViewport();
         const newElements = addNode(getVisibleBounds(viewport));
-        if(point) {
-            const adjust = (offset:number) => {
+        if (point) {
+            const adjust = (offset: number) => {
                 return (offset / viewport.zoom) - (NODE_SIZE / 2);
-            }
+            };
             newElements[0].position = {
                 x: viewport.scroll.x + adjust(point.x),
                 y: viewport.scroll.y + adjust(point.y)
@@ -99,7 +99,7 @@ export default async function runCircleGraph() {
 
     // Button features
     document.getElementById('addNode')!.addEventListener('click', async () => {
-        createNode()
+        createNode();
     });
 
     document.getElementById('scrambleAll')!.addEventListener('click', async () => {

diff --git a/examples/classdiagram/src/menu.ts b/examples/classdiagram/src/menu.ts
@@ -30,18 +30,19 @@ export class ClassContextMenuService implements IContextMenuService {
     @inject(TYPES.ViewerOptions) protected viewerOptions: ViewerOptions;
 
     show(items: MenuItem[], anchor: Anchor, onHide?: (() => void) | undefined): void {
-        this.actionDispatcher.dispatch(SetPopupModelAction.create(EMPTY_ROOT))
+        this.actionDispatcher.dispatch(SetPopupModelAction.create(EMPTY_ROOT));
         const container = document.getElementById(this.viewerOptions.baseDiv);
+        // eslint-disable-next-line prefer-const
         let menuNode: HTMLDivElement;
         const hideMenu = () => {
             container?.removeChild(menuNode);
             if (onHide) {
-                onHide()
+                onHide();
             }
-        }
+        };
         menuNode = this.createMenu(items, hideMenu);
-        menuNode.style.top = (anchor.y - 5) + 'px'
-        menuNode.style.left = (anchor.x - 5) + 'px'
+        menuNode.style.top = (anchor.y - 5) + 'px';
+        menuNode.style.left = (anchor.x - 5) + 'px';
 
 
         container?.appendChild(menuNode);
@@ -65,7 +66,7 @@ export class ClassContextMenuService implements IContextMenuService {
                 if (itemEnabled && item.actions.length > 0) {
                     this.actionDispatcher.dispatchAll(item.actions);
                 }
-            }
+            };
             menuNode.appendChild(menuItem);
         });
         return menuNode;
@@ -78,7 +79,7 @@ export class ClassContextMenuItemProvider implements IContextMenuItemProvider {
     @inject(TYPES.IActionDispatcher) readonly actionDispatcher: IActionDispatcher;
 
     async getItems(root: Readonly<SModelRootImpl>, lastMousePosition?: Point | undefined): Promise<LabeledAction[]> {
-        const selectionResult = await this.actionDispatcher.request<SelectionResult>(GetSelectionAction.create())
+        const selectionResult = await this.actionDispatcher.request<SelectionResult>(GetSelectionAction.create());
         return [
             new LabeledAction('Fit Diagram to Screen', [FitToScreenAction.create(root.children.map(child => child.id))]),
             new LabeledAction('Center Selection', [CenterAction.create(selectionResult.selectedElementsIDs)]),
@@ -88,7 +89,7 @@ export class ClassContextMenuItemProvider implements IContextMenuItemProvider {
             {
                 ...new LabeledAction('Delete Selected', [DeleteElementAction.create(selectionResult.selectedElementsIDs)]),
                 isEnabled: () => {
-                    return selectionResult.selectedElementsIDs.length > 0
+                    return selectionResult.selectedElementsIDs.length > 0;
                 }
             } as MenuItem
         ];