Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2192 upgrade jsonld-java and jackson + fix for test #2233

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

barthanssens
Copy link
Contributor

@barthanssens barthanssens commented May 17, 2020

GitHub issue resolved: #2192

Briefly describe the changes proposed in this PR:

  • updated jackson dependencies
  • updated json-ld java
  • small change in test
  • include newer snake YAML dependency for ES compliance test

PR Author Checklist:

  • my pull request is self-contained
  • I've added tests for the changes I made
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
  • every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

@barthanssens
Copy link
Contributor Author

It seems to fail randomly on the Jenkins machine (or perhaps JDK13), I'll have to check again.

It's probably good idea to wait for the release of Jackson 2.10.5 anyway, since there is an annoying JSON allow-missing-value bug (FasterXML/jackson-core#616)

@barthanssens
Copy link
Contributor Author

Issue in compliance test .ElasticsearchSailGeoSPARQLTest, snakeyaml dependency, could be due to different jackson versions used by elasticsearch-x-content

@abrokenjester
Copy link
Contributor

Unfortunately it looks as if excluding the older version does not work - at least locally for me it doesn't. I've pushed the original fix you had in mind, which is to include the newer version as an explicit (test) dependency.

@abrokenjester
Copy link
Contributor

abrokenjester commented Jul 5, 2020

Argh that's annoying. I've started using the gh command to check out local copies of pulll request from forked repos (such as Fedict). But unlike the old hub command, when I push, it just creates a new branch on the origin rather than pushing back to the fork.

@abrokenjester
Copy link
Contributor

...and it also looks as if I don't have editing rights on your fork Bart.

@abrokenjester
Copy link
Contributor

I've created a pull request on your fork to resolve this. Fedict#10. I'm sure there must an easier way but my Sunday-brain won't let me think of it.

@barthanssens
Copy link
Contributor Author

Thanks @jeenbroekstra , original idea appears indeed the only one that works. Other attempts did often work once on my local machine, but re-running clean install -P verify failed on a second run ...

I'd suggest to use Snakeyaml 1.25, since there is already a CQ21086 for it

@barthanssens barthanssens merged commit 54ed00d into eclipse-rdf4j:develop Jul 5, 2020
@barthanssens barthanssens deleted the GH-2192-jsonld-jackon branch October 1, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants