Replace deprecated File.toURL()

[elsazac]

java.io.File.toURL() is deprecated and marked for removal. Replace it with file.toURI().toURL(), where toURL() is called on a java.net.URI instance, which is not deprecated and handles encoding correctly.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 694884198d643a9fe071043683f574083c0ede0c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 30 Apr 2025 10:44:45 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index 5f045c7318..f1a5deb034 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.600.qualifier
+Bundle-Version: 3.5.700.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 28m 50s ⏱️ - 4m 24s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 85b56c2. ± Comparison against base commit 9bbb5b0.

♻️ This comment has been updated with latest results.

[HannesWell]

I'm not sure if this is a place we want to fix because, as also mentioned in #35 (comment), the URL produced here potentially reaches client code outside of the Eclipse platform and they might expect it to be wrongly encoded just as it used to be. So fixing this might be a compatibility problem.
I believe that is also the reason that all the FileLocator methods where not yet fixed to return properly encoded URLs, but I don't know the exact discussion about this.
Maybe @tjwatson or @merks know if/when/where this was discussed?

In general please be very careful when fixing the URL conversions. The change looks so simple, but it can cause major compatibility problems in unfortunate cases.

[tjwatson]

Just to name a few old bugs, I'm sure there are more:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=126310
https://bugs.eclipse.org/bugs/show_bug.cgi?id=145096
https://bugs.eclipse.org/bugs/show_bug.cgi?id=188685

[elsazac]

@HannesWell
How did you identify that this URL might be accessed by client code outside the platform? Was that based on the method being public or something specific in the code? Just trying to understand the scenario better.

[merks]

Such changes are really scary. You would be shocked how many places expect the url not to be properly encoded. Unless we have extensive tests with paths with spaces, the % character, and non-ascii characters I can pretty much guarantee you that things will go wrong.

Don’t do this in isolation.