Only start the stream monitoring after events are send out

[laeubi]

Currently it is almost impossible to capture the full binary stream of a process even if one adds a listener right after creation of the stream proxy. The reason is that the streams are immediately started to being read in the constructor. The code currently uses some caching in place but this only works reliable for a single listener and is then reset afterwards having other missing data depending on how fast they can register. Even worse there is a small chance that after registration and before reading the buffer some bytes are received and then is processed before the buffer contents.

This now creates a new constructor that only creates the stream but do not start them. Instead users must call the method startMonitoring for this. The RuntimeProcess now uses this constructor to delay the start of stream reading unless all notifications are performed so other parties can register accordingly.

See

• Add support for launching Eclipse Process in a system terminal session #1762

[github-actions]

Test Results

1 214 files  ±0  1 214 suites  ±0   1h 0m 30s ⏱️ + 1m 12s
4 173 tests ±0  4 127 ✅ ±0   46 💤 ±0  0 ❌ ±0 
9 541 runs  ±0  9 420 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit ee99fbe. ± Comparison against base commit e8c3e2d.