Feature request: Extend AbstractSearchProcessor#postSearch(...) of the org.eclipse.help.searchProcessor extension point
#1725
+70
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `org.eclipse.help.searchProcessor` extension point allows to modify the help search results. This is done by calling the `postSearch(...)` method of all implementations of `org.eclipse.help.search.AbstractSearchProcessor` specified by this extension point. In some cases, the search results to be modified and the query that are passed as parameters to the `postSearch(...)` method may not be enough. So this change adds another `postSearch(...)` method with additional parameters like the locale and the scopes if any. The simpler `postSearch(...)` is be kept for backward compatibility. Additionally, if `preSearch(...)` returns a `SearchProcessorInfo` with an empty, non-`null` query (`""`), no search will be executed, resulting in no search results or in the search results that has been added via `postSearch(...)`.
howlger
force-pushed
the
patch-searchProcessor
branch
from
c74b88b to
a202f0c
Compare
|
@iloveeclipse This is a work for Advantest and may be helpful for others too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
org.eclipse.help.searchProcessorextension point allows to modify the help search results. This is done by calling thepostSearch(...)method of all implementations oforg.eclipse.help.search.AbstractSearchProcessorspecified by this extension point. In some cases, the search results to be modified and the query that are passed as parameters to thepostSearch(...)method may not be enough. So this change adds anotherpostSearch(...)method with additional parameters like the locale and the scopes if any. The simplerpostSearch(...)is be kept for backward compatibility.Additionally, if
preSearch(...)returns aSearchProcessorInfowith an empty, non-nullquery (""), no search will be executed, resulting in no search results or in the search results that has been added viapostSearch(...).