Simplify and improve assertions in Ant core tests #903 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
assertions-ant-core
branch
from
7acda8c to
f67133c
Compare
HeikoKlare
force-pushed
the
assertions-ant-core
branch
2 times, most recently
from
e8081d2 to
4db13a7
Compare
HeikoKlare
force-pushed
the
assertions-ant-core
branch
3 times, most recently
from
2379798 to
9aad5ce
Compare
Simplifies and/or improves several assertions in org.eclipse.ant.core.tests - Replace assertTrue/assertFalse with assertEquals/assertThat - Remove obsolete assertions messages just repeating the assertions This also prepares for a migration of assertions to JUnit 5. Contributes to eclipse-platform#903
HeikoKlare
force-pushed
the
assertions-ant-core
branch
from
9aad5ce to
50ceb59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies and/or improves several assertions in org.eclipse.ant.core.tests
This also prepares for a migration of assertions to JUnit 5.
Contributes to #903