-
Notifications
You must be signed in to change notification settings - Fork 128
Remove unused native code and assume unicode is always supported in Win32Natives refresh provider #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused native code and assume unicode is always supported in Win32Natives refresh provider #1415
Conversation
12af28b
to
f4a2bee
Compare
This commit would rely for example on https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-findfirstchangenotificationw |
That's correct and the same applies for the removed code, for example Both, the A suffixed and W suffixed methods have been introduced when Unicode support was added in Windows XP: Besides that there is only a 64-bit fragment With all that |
6b8fd28
to
b86da90
Compare
If the "A" and "W" variants where introduced at the same time i don't get if that "A" code was ever used or needed. |
Unicode support was assumed to be present if the Windows-OS version is greater or equal five, which corresponds to Windows 2000 or later [1]. Because parts of the removed and remaining native code call methods that are only available on Windows XP/Server 2003 or later, for example 'FindFirstChangeNotificationA()' respectively 'FindFirstChangeNotificationW()', it is save to assume Unicode is always supported. All methods that check it or handle an alternative encoding are effectively dead code and can be removed. Furthermore only 64-bit artifacts are provided now and 64-bit CPU are not supported before Windows XP, too. [1] - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversioninfow
b86da90
to
bb4c48a
Compare
I'm not sure either, so I can only guess. But then lets not further delay this and submit it. |
Unicode support is assumed to be present if the Windows-OS version is greater or equal five, which corresponds to Windows 2000 or later: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversioninfow
For example the JDK binaries provided by Temurin and Oracle require at least Windows-8 for a JDK-17:
and given that even Windows-10 will be EOL in about a year I think we can confidently remove that support for pre Windows 2000 versions.
This was originally part of #1394.