Redesign Message Dialog #2934

SougandhS · 2025-04-23T01:13:03Z

Removes unwanted space and aligns message content & buttons to center

Before

After

Fixes : #2929

github-actions · 2025-04-23T05:23:03Z

Test Results

1 824 files ±0 1 824 suites ±0 1h 30m 39s ⏱️ - 7m 15s
7 918 tests ±0 7 690 ✅ +1 228 💤 ±0 0 ❌ - 1
23 841 runs ±0 23 093 ✅ +1 748 💤 ±0 0 ❌ - 1

Results for commit cd6224c. ± Comparison against base commit e6eb975.

mickaelistria · 2025-04-23T13:10:15Z

As the discussion on the bug reveals, there is no obvious consensus to find between aligned left vs centered; however, all OSs recommend to get the width fit the content (ie no extra space), so I think for a first iteration, we should focus on just saving the extra space (changing the min width to 0 or DEFAULT), and consider whether to center or not later; maybe if all OSs align on the same recommendation some day.

SougandhS · 2025-04-24T06:13:52Z

Updated one

mickaelistria · 2025-04-25T11:57:27Z

I'm seeing an issue with the given patch: the MessageDialog now tends to become too large:

Before

After

SougandhS · 2025-04-26T05:40:38Z

I'm seeing an issue with the given patch: the MessageDialog now tends to become too large:

Made minor adjustment for these cases

merks

I think changing the horizontalSpan is a bad idea. I'm not even sure why it's needed.

merks · 2025-04-26T07:43:42Z

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java

@@ -328,7 +328,6 @@ protected Control createDialogArea(Composite parent) {
 		layout.marginWidth = 0;
 		composite.setLayout(layout);
 		GridData data = new GridData(GridData.FILL_BOTH);
-		data.horizontalSpan = 2;


I thought there was previously already feedback about this change affecting all subclasses. There are a great many so this seems not a good idea at all.

Sorry, I had only configured the platform UI code in my workspace, which caused me to overlook the impact on the subclasses. I've now reverted the change and adjusted the value to 1 to remove the extra space.

See

about a regression caused by changing the span.

merks · 2025-04-26T07:44:13Z

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IconAndMessageDialog.java

@@ -100,13 +100,14 @@ protected Control createMessageArea(Composite composite) {
 		if (message != null) {
 			messageLabel = new Label(composite, getMessageLabelStyle());
 			messageLabel.setText(message);
+			int minWidthHint = convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH - 50);


It's odd to compute this in advance and then only use it conditionally later.

merks · 2025-04-26T07:45:03Z

bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IconAndMessageDialog.java

-							convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH),
-							SWT.DEFAULT).applyTo(messageLabel);
+					.indent(5, 0)
+					.hint(message.length() > 40 ? minWidthHint : SWT.DEFAULT, SWT.DEFAULT)


The number 40 is quite magic. I wonder how things like font size and scaling might affect what this number should be?

I tested the implementation with few different font sizes and found the results to be satisfactory, which is why I proceeded with this approach.

BeckerWdf · 2025-04-28T11:54:01Z

I asked our inhouse UX-Experts. This is what they say:

We would not recommend the centered alignment of dialog content in Eclipse – even for short texts like "Save ‘NAME.filetype‘?" – for several reasons:

This dialog is displayed for only a few seconds and does not obscure any relevant content. Removing the empty line between the text and the buttons, as well as centering the text, worsens readability – we do not see any advantages in this approach.
Left-aligned dialogs with right-aligned buttons are common desktop practices (e.g., Windows, macOS). Centered dialogs are more typical in mobile UIs where space is limited. On the desktop, space shouldn't be an issue.
Prompts would wrap to two lines in the centered dialog quite easily. The current "airy issue" with short names could potentially turn into a "squeezed issue" with long names.

SougandhS · 2025-04-28T23:55:31Z

I asked our inhouse UX-Experts. This is what they say:

Thanks for checking ✨

akurtakov · 2025-04-29T04:32:45Z

@SougandhS So are you going to continue with some other ideas here or are you giving up on the idea (and the PR should be closed)?

SougandhS · 2025-04-29T04:40:58Z

@SougandhS So are you going to continue with some other ideas here or are you giving up on the idea (and the PR should be closed)?

I have a small idea.. [ Not sure everyone agrees :) ]
For small texts can we reduce the width a bit atleast ?

SougandhS · 2025-04-29T04:49:35Z

I have a small idea.. [ Not sure everyone agrees :) ] For small texts can we reduce the width a bit atleast ?

BeckerWdf · 2025-04-29T06:13:14Z

I have a small idea.. [ Not sure everyone agrees :) ] For small texts can we reduce the width a bit atleast ?

Where's the difference?

SougandhS · 2025-04-29T06:24:48Z

Where's the difference?

Before

after

BeckerWdf · 2025-04-29T06:33:54Z

and how does this change look for other dialogs?

SougandhS · 2025-04-29T07:19:17Z

and how does this change look for other dialogs?

Yes did checked one
Before

After

Removed unnecessary spacing in the message dialog to improve visual alignment and create a more compact, cleaner layout. Fixes : eclipse-platform#2929

mickaelistria · 2025-04-29T07:52:49Z

I don't see a clear benefit with this change. IMO, the desired format is #2934 (comment) and anything else is not worth being pursued.
I don't know the details about why #2934 (comment) cannot be implemented reliably. Is it because changing the horizontal span is required? Aren't there alternative that can be found? eg is the 2 columns layout used because of image? If so, then couldn't we dynamically decide of the span or layout according to whether image is null or not?

SougandhS · 2025-04-29T10:10:22Z

eg is the 2 columns layout used because of image? If so, then couldn't we dynamically decide of the span or layout according to whether image is null or not?

I tried modifying IconAndMessageDialog.getColumnCount() to return 1, but the extra space remained regardless of Image. It only disappeared after I also updated data.horizontalSpan = 1 in MessageDialog.createDialogArea(Composite).

SougandhS force-pushed the SaveBoxAlignment branch from cd6224c to f549998 Compare April 24, 2025 06:13

SougandhS force-pushed the SaveBoxAlignment branch from f549998 to 0100808 Compare April 26, 2025 05:39

SougandhS force-pushed the SaveBoxAlignment branch from 0100808 to 1db3a95 Compare April 26, 2025 05:42

merks requested changes Apr 26, 2025

View reviewed changes

SougandhS force-pushed the SaveBoxAlignment branch 2 times, most recently from 4c05420 to 4045e5d Compare April 28, 2025 04:15

SougandhS force-pushed the SaveBoxAlignment branch from 4045e5d to e8c7042 Compare April 29, 2025 07:28

Make message dialog more compact

21f7226

Removed unnecessary spacing in the message dialog to improve visual alignment and create a more compact, cleaner layout. Fixes : eclipse-platform#2929

SougandhS force-pushed the SaveBoxAlignment branch from e8c7042 to 21f7226 Compare April 29, 2025 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign Message Dialog #2934

Redesign Message Dialog #2934

SougandhS commented Apr 23, 2025

github-actions bot commented Apr 23, 2025

mickaelistria commented Apr 23, 2025

SougandhS commented Apr 24, 2025 •

edited

Loading

mickaelistria commented Apr 25, 2025 •

edited

Loading

SougandhS commented Apr 26, 2025

merks left a comment

merks Apr 26, 2025

SougandhS Apr 28, 2025

mickaelistria Apr 28, 2025

merks Apr 26, 2025

SougandhS Apr 28, 2025

merks Apr 26, 2025

SougandhS Apr 28, 2025

BeckerWdf commented Apr 28, 2025

SougandhS commented Apr 28, 2025

akurtakov commented Apr 29, 2025

SougandhS commented Apr 29, 2025

SougandhS commented Apr 29, 2025 •

edited

Loading

BeckerWdf commented Apr 29, 2025

SougandhS commented Apr 29, 2025

BeckerWdf commented Apr 29, 2025

SougandhS commented Apr 29, 2025

mickaelistria commented Apr 29, 2025

SougandhS commented Apr 29, 2025

Redesign Message Dialog #2934

Are you sure you want to change the base?

Redesign Message Dialog #2934

Conversation

SougandhS commented Apr 23, 2025

github-actions bot commented Apr 23, 2025

Test Results

mickaelistria commented Apr 23, 2025

SougandhS commented Apr 24, 2025 • edited Loading

mickaelistria commented Apr 25, 2025 • edited Loading

SougandhS commented Apr 26, 2025

merks left a comment

Choose a reason for hiding this comment

merks Apr 26, 2025

Choose a reason for hiding this comment

SougandhS Apr 28, 2025

Choose a reason for hiding this comment

mickaelistria Apr 28, 2025

Choose a reason for hiding this comment

merks Apr 26, 2025

Choose a reason for hiding this comment

SougandhS Apr 28, 2025

Choose a reason for hiding this comment

merks Apr 26, 2025

Choose a reason for hiding this comment

SougandhS Apr 28, 2025

Choose a reason for hiding this comment

BeckerWdf commented Apr 28, 2025

SougandhS commented Apr 28, 2025

akurtakov commented Apr 29, 2025

SougandhS commented Apr 29, 2025

SougandhS commented Apr 29, 2025 • edited Loading

BeckerWdf commented Apr 29, 2025

SougandhS commented Apr 29, 2025

BeckerWdf commented Apr 29, 2025

SougandhS commented Apr 29, 2025

mickaelistria commented Apr 29, 2025

SougandhS commented Apr 29, 2025

SougandhS commented Apr 24, 2025 •

edited

Loading

mickaelistria commented Apr 25, 2025 •

edited

Loading

SougandhS commented Apr 29, 2025 •

edited

Loading