Skip to content

[GTK] Remove temporary workaround for LineNumberRulerColumn #2740 #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HeikoKlare
Copy link
Contributor

The underlying issue for the required workaround on Linux/GTK was located in the GTK implementation of GC#copyArea() when source and target area of a copy operation are overlapping. Since that issue has been fixed, this change removes the temporary workaround in LineNumberRulerColumn.

Fixes #2740

⚠️ This depends on the SWT fix eclipse-platform/eclipse.platform.swt#1757

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Test Results

 1 821 files  +  607   1 821 suites  +607   1h 28m 1s ⏱️ + 37m 8s
 7 717 tests ±    0   7 489 ✅ ±    0  228 💤 ±  0  0 ❌ ±0 
24 312 runs  +8 104  23 563 ✅ +7 823  749 💤 +281  0 ❌ ±0 

Results for commit ae96150. ± Comparison against base commit ec4235b.

♻️ This comment has been updated with latest results.

…latform#2740

The underlying issue for the required workaround on Linux/GTK was
located in the GTK implementation of GC#copyArea() when source and
target area of a copy operation are overlapping. Since that issue has
been fixed, this change removes the temporary workaround in
LineNumberRulerColumn.

Fixes eclipse-platform#2740
@HeikoKlare HeikoKlare force-pushed the issue-2740-remove-workaround branch from f07cfa0 to ae96150 Compare January 25, 2025 07:34
@HeikoKlare HeikoKlare marked this pull request as ready for review January 25, 2025 07:34
@HeikoKlare HeikoKlare merged commit 1042a13 into eclipse-platform:master Jan 25, 2025
17 checks passed
@HeikoKlare HeikoKlare deleted the issue-2740-remove-workaround branch January 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Line Numbers are broken in different ways on Linux/MacOS
1 participant