Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Theme]Fix for background color of gutter line in editor #2744

Merged

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Jan 22, 2025

Implementing fix for gutter line background change in dark theme for Win, Mac and Linux.
Ref 4th issue reported in #2114 (comment)

Will update before and after images soon.

@BeckerWdf
Copy link
Contributor

This is the before and After on macOS
BeforeAndAfter

Looks good to me.

Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 27m 54s ⏱️ - 2m 30s
 7 715 tests ±0   7 487 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 306 runs  ±0  23 557 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 056b281. ± Comparison against base commit 25cd854.

@BeckerWdf BeckerWdf merged commit 4a38dc8 into eclipse-platform:master Jan 22, 2025
17 checks passed
@BeckerWdf
Copy link
Contributor

Thanks

@mvm-sap mvm-sap deleted the Gutterline_issue_in_dark_theme branch January 23, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants